[
https://issues.apache.org/jira/browse/SERF-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18049023#comment-18049023
]
Branko Čibej commented on SERF-211:
-----------------------------------
The async resolver as a whole is an experimental feature. We can decide that
it's not and just remove the "experimental" annotations.
The TODO comment about waking up serf_context_run(): this could be an
enhancement, but is not critical to functionality. We should assume that the
timeout for serf_context_run is short enough.
The catch is that we may not have control over how to awake the context because
it can be completely controlled by the application, there's no guarantee that
serf_context_run() will even be called. So, maybe, for this reason, we should
keep the async resolve experimental in 1.5.
> Finalise async resolver
> -----------------------
>
> Key: SERF-211
> URL: https://issues.apache.org/jira/browse/SERF-211
> Project: serf
> Issue Type: Bug
> Reporter: Daniel Sahlberg
> Priority: Major
>
> The async resolver code contains a bunch of FIXMEs:
>
> resolve.c
> /*
> * FIXME: EXPERIMENTAL
> * TODO:
> * - Wake the poll/select in serf_context_run() when new resolve
> * results are available.
> */
>
> init_once.c
> /* FIXME: Do we really want to support APR-0.9.x? */
> {color:#FF0000}(no?){color}
> return APR_EGENERAL; /* FIXME: Just abort()? */ {color:#FF0000}(as the
> previous comment says: It can't happen, was there some stupid compiler
> complaining?){color}
>
> serf.h
> /* FIXME: EXPERIMENTAL */
> (four times, on the declarations of the async functions/callbacks)
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
