On 9. 1. 26 17:32, Ivan Zhakov wrote:
On Fri, 9 Jan 2026 at 10:52, Branko Čibej<[email protected]> wrote:
This is a philosophical question.
The header serf_private.h uses symbols from serf.h but doesn't #include
serf.h. Personally I find this a constant distraction, especially when
my IDE (a.k.a. Emacs) complains about undefined symbols.
Is there a deeper reason that serf_private.h doesn't include serf.h?
I think it's just oversight.
Because it either should include it, or should stop depending on
typedefs from serf.h.
The reason I bring this up: I'm going through the files, looking for
#include inconsistencies, and there are a lot of places where we include
both serf.h and serf_private.h, even though one of them isn't needed.
I agree: generally all headers should supported including without
prerequisites, unless strong reasons.
I suggest just to add #include "serf.h".
Done in r1931208.
-- Brane
