> >> Just add 14.5 to the list. And probably remove anything older than, > >> what, 10? I don't think the versions of Windows that used those > >> compilers even exist any more, except possibly in some strange airgapped > >> environment that may as well use an older version of Serf. > > I'm concerned that by just adding it to the list, because as a new > > version (of MSVC) comes out, it will break the build once again. This > > at least "patches" the problem so I'm still planning to prepare a fix > > for that. > > > > I believe there should be a more elegant and generalised solution for > > the issue of detecting the compiler. > > We're not detecting the compiler. This appears to be a cross-check > between MSVC version and SCons support for it. See SConstruct around > line 187 `if sys.platform == 'win32':`. > > The last changes in this area were in r1909315 and r1909316. I think we > can handle one commit every 2 years to track this. We can look for a > better way once we decide which build system to keep, CMake or SCons.
Okay, can serf release a patch to the build system in a few weeks after a new version of MSVC is out? I honestly don't think so. > As the saying goes, premature optimisation is the root of all evil. That is true, but this is not an optimisation but a design problem. By the way, I found a related issue on scons' github with ~100 comments [1]. They don't seem to come up with a canonical solution. However, I could have missed something from it. [1] https://github.com/SCons/scons/issues/3664 -- Timofei Zhakov
