wujimin commented on a change in pull request #476: [SCB-85] Upgrade Metrics
File Output from 0.5.0 to 1.0.0-m1
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r160050452
##########
File path:
foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/MetricsServoRegistry.java
##########
@@ -563,7 +563,7 @@ public String getValue() {
}
private double round(double value, int places) {
- if (!Double.isNaN(value) && !Double.isInfinite(value)) {
+ if (!Double.isNaN(value)) {
BigDecimal decimal = new BigDecimal(value);
return decimal.setScale(places, RoundingMode.HALF_UP).doubleValue();
} else {
Review comment:
already return, do not write "else"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
