little-cui commented on a change in pull request #248: optimize quota check log
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/248#discussion_r161352771
##########
File path: server/service/schema.go
##########
@@ -507,7 +503,7 @@ func (s *MicroServiceService) ModifySchema(ctx
context.Context, request *pb.Modi
if err != nil {
util.Logger().Errorf(err, "modify schema failed, serviceId %s,
schemaId %s", serviceId, schemaId)
resp := &pb.ModifySchemaResponse{
- Response: pb.CreateResponse(err.Code, err.Detail),
+ Response: pb.CreateResponseWithSCErr(err),
}
if err.StatusCode() == http.StatusInternalServerError {
Review comment:
Use the err.InternalError()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
