WillemJiang commented on a change in pull request #113: SCB-211 wait until 
connection recover instead of try sending
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/113#discussion_r161396088
 
 

 ##########
 File path: 
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/PushBackReconnectRunnable.java
 ##########
 @@ -31,26 +33,39 @@
   private final Map<MessageSender, Long> senders;
   private final BlockingQueue<Runnable> pendingTasks;
 
+  private final ReentrantLock lock;
+
+  private final Condition condition;
+
   PushBackReconnectRunnable(
       MessageSender messageSender,
       Map<MessageSender, Long> senders,
-      BlockingQueue<Runnable> pendingTasks) {
+      BlockingQueue<Runnable> pendingTasks,
+      ReentrantLock lock,
+      Condition condition) {
     this.messageSender = messageSender;
     this.senders = senders;
     this.pendingTasks = pendingTasks;
+    this.lock = lock;
+    this.condition = condition;
   }
 
   @Override
   public void run() {
+    lock.lock();
 
 Review comment:
   why do we need the lock here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to