WillemJiang commented on a change in pull request #510: [SCB-12] Support Custom 
Metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/510#discussion_r161717861
 
 

 ##########
 File path: 
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthCheckerManager.java
 ##########
 @@ -84,5 +97,8 @@ public void testRegistry() throws IOException {
     Assert.assertTrue(data.getInstanceId().equals("001"));
 
 Review comment:
   It makes sense to use the assertEquals instead of assertTrue here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to