wujimin commented on a change in pull request #522: [SCB-266] Support generic
rest
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/522#discussion_r162770311
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
##########
@@ -118,7 +118,25 @@ public void pullInstances() {
List<MicroserviceInstance> pulledInstances =
microserviceInstances.getInstancesResponse().getInstances();
String rev = microserviceInstances.getRevision();
- setInstances(pulledInstances, rev);
+ safeSetInstances(pulledInstances, rev);
+ }
+
+ protected void safeSetInstances(List<MicroserviceInstance> pulledInstances,
String rev) {
+ try {
+ setInstances(pulledInstances, rev);
Review comment:
or failed to request from sc
if happened, exception eat by scheduled thread pool, we can not know there
is a exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
