Hi Sean Yin, Your fix worked, thank you.
On Mon, Jan 22, 2018 at 11:10 AM, Sean Yin <[email protected]> wrote: > Hi Yang Bo, > > We can just exclude them from our project. I will do it. > > On Mon, Jan 22, 2018 at 10:09 AM, Yang Bo <[email protected]> wrote: > > > Hi, > > > > I'm preparing the NOTICE file for saga 1.0 release and I'm having the > > following problems: > > > > 1. The Saga project depends on Java Chassis project which includes > > FindBugs-Annotations (http://findbugs.sourceforge.net/) > > com.google.code.findbugs:annotations:jar:2.0.0 > > which is under LGPL. We have fixed this in the Java Chassis project, but > > it's group is changed to 'servicecomb.apache.org'. But the Saga project > > still uses the 'io.servicecom' group. > > > > Shall we release Saga after Java Chassis? Or is it OK that we release > Saga > > first knowing that the dependency on findbugs:annotations will be removed > > later? > > > > 2. The Saga project includes the json library which is under the JSON > > license. > > > > The json library is imported by hamcrest-json and > spring-boot-starter-test, > > maybe we can exclude the dependency in the pom? > > > > org.json:json:jar:20090211 > > org.json:json:jar:20140107 > > --- > > [INFO] +- com.github.seanyinx:unit-scaffolding:jar:1.0.0:test > > [INFO] \- uk.co.datumedge:hamcrest-json:jar:0.2:test > > [INFO] \- org.skyscreamer:jsonassert:jar:1.1.1:test > > [INFO] +- org.json:json:jar:20090211:test > > > > [INFO] +- > > org.springframework.boot:spring-boot-starter-test:jar:1.4.5.RELEASE:test > > [INFO] | +- > > org.springframework.boot:spring-boot-test:jar:1.4.5.RELEASE:test > > [INFO] | +- > > org.springframework.boot:spring-boot-test-autoconfigure:jar:1.4.5. > > RELEASE:test > > [INFO] | +- com.jayway.jsonpath:json-path:jar:2.2.0:test > > [INFO] | | \- net.minidev:json-smart:jar:2.2.1:test > > [INFO] | | \- net.minidev:accessors-smart:jar:1.1:test > > [INFO] | | \- org.ow2.asm:asm:jar:5.0.3:test > > [INFO] | +- org.assertj:assertj-core:jar:2.5.0:test > > [INFO] | +- org.hamcrest:hamcrest-core:jar:1.3:test > > [INFO] | +- org.hamcrest:hamcrest-library:jar:1.3:test > > [INFO] | +- org.skyscreamer:jsonassert:jar:1.3.0:test > > [INFO] | | \- org.json:json:jar:20140107:test > > > > > > [INFO] | +- > > org.springframework.boot:spring-boot-starter-test:jar: > > 1.4.5.RELEASE:compile > > [INFO] | +- > > org.springframework.boot:spring-boot-test:jar:1.4.5.RELEASE:compile > > [INFO] | +- > > org.springframework.boot:spring-boot-test-autoconfigure:jar:1.4.5. > > RELEASE:compile > > [INFO] | +- com.jayway.jsonpath:json-path:jar:2.2.0:compile > > [INFO] | | \- net.minidev:json-smart:jar:2.2.1:compile > > [INFO] | | \- net.minidev:accessors-smart:jar:1.1:compile > > [INFO] | | \- org.ow2.asm:asm:jar:5.0.3:compile > > [INFO] | +- org.assertj:assertj-core:jar:2.5.0:compile > > [INFO] | +- org.mockito:mockito-core:jar:1.10.19:test > > [INFO] | | \- org.objenesis:objenesis:jar:2.1:test > > [INFO] | +- org.hamcrest:hamcrest-core:jar:1.3:test > > [INFO] | +- org.hamcrest:hamcrest-library:jar:1.3:compile > > [INFO] | +- org.skyscreamer:jsonassert:jar:1.3.0:compile > > [INFO] | | \- org.json:json:jar:20140107:compile > > --- > > >
