seanyinx commented on a change in pull request #117: SCB-224 support retry
sub-transaction
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/117#discussion_r163727595
##########
File path:
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java
##########
@@ -75,11 +72,11 @@ private void pollEvents() {
}
private void saveUncompensatedEventsToCommands() {
-
eventRepository.findFirstUncompensatedEventByIdGreaterThan(nextEndedEventId,
TxEndedEvent.name())
+ eventRepository.findByTypeAndIdGreaterThan(nextAbortedEventId,
TxAbortedEvent.name())
Review comment:
we can't fully depend on AbortedEvent here, since TxStartedEvent and
TxEndedEvent of some sub transaction may arrive later, causing some events are
not compensated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
