wujimin commented on a change in pull request #527: [SCB-297] The local cache
is not update when the server reboots at th?
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/527#discussion_r163528413
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
##########
@@ -195,11 +196,13 @@ protected MicroserviceVersionRule
createAndInitMicroserviceVersionRule(String st
@Subscribe
public void onMicroserviceInstanceChanged(MicroserviceInstanceChangedEvent
changedEvent) {
- if (!appId.equals(changedEvent.getKey().getAppId()) ||
- !microserviceName.equals(changedEvent.getKey().getServiceName())) {
+ boolean isEventAccept = appId.equals(changedEvent.getKey().getAppId()) &&
Review comment:
wrong logic
do you know what's this means?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
