WillemJiang commented on a change in pull request #538: SCB-315 add common
AddressResover configuration to foundation-vertx, and use it in
service-registry and config-cc to support dynamic config by user
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/538#discussion_r164455281
##########
File path:
foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestAddressResoverConfig.java
##########
@@ -40,8 +61,7 @@ public void testGetResover() {
ArchaiusUtils.setProperty("addressResolver.ndots", 3);
ArchaiusUtils.setProperty("addressResolver.rotateServers", true);
AddressResolverOptions aroc =
AddressResolverConfig.getAddressResover("test");
- Assert.assertEquals(2, aroc.getServers().size());
- Assert.assertEquals("8.8.8.8", aroc.getServers().get(0));
+ Assert.assertThat(aroc.getServers(), is(Arrays.asList("8.8.8.8",
"8.8.4.4")));
Assert.assertEquals("test.svc.local.cluster",
aroc.getSearchDomains().get(0));
AddressResolverOptions aroc1 =
AddressResolverConfig.getAddressResover("test1");
Review comment:
Please use assertThat here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
