liubao68 commented on a change in pull request #531: [SCB-252] Overwatch
Integration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/531#discussion_r164942622
##########
File path:
metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsPublisher.java
##########
@@ -36,7 +36,7 @@
@Component
public class MetricsPublisher implements ApplicationListener<ApplicationEvent>
{
- private static final Logger LOGGER =
LoggerFactory.getLogger(MetricsPublisher.class);
+ private static final Logger logger =
LoggerFactory.getLogger(MetricsPublisher.class);
Review comment:
why changed to logger? for static final varibles, use upper case, see this
code below(METRICS_PROMETHEUS_PORT).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
