[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

[GitBox]

WillemJiang commented on a change in pull request #555: [SCB-327] Update 
metrics publish data module (Re-organized)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168057392
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/Invocation.java
 ##########
 @@ -188,15 +188,16 @@ public String getMicroserviceQualifiedName() {
   public void triggerStartProcessingEvent() {
     this.startProcessingTime = System.nanoTime();
     EventUtils.triggerEvent(new InvocationStartProcessingEvent(
-        operationMeta.getMicroserviceQualifiedName(), this.invocationType, 
startProcessingTime - startTime));
+        operationMeta.getMicroserviceQualifiedName(), this.invocationType));
   }
 
-  public void triggerFinishedEvent(int statusCode, boolean success) {
+  public void triggerFinishedEvent(int statusCode) {
     long finishedTime = System.nanoTime();
     EventUtils
-        .triggerEvent(new 
InvocationFinishedEvent(operationMeta.getMicroserviceQualifiedName(),
-            this.invocationType, finishedTime - startProcessingTime,
-            finishedTime - startTime, statusCode, success));
+        .triggerEvent(new 
InvocationFinishedEvent(operationMeta.getMicroserviceQualifiedName(), 
this.invocationType,
+            startProcessingTime - startTime,
 
 Review comment:
   Can you explain the meaning of startTime, startProcessingTime?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services