WillemJiang commented on a change in pull request #555: [SCB-327] Update
metrics publish data module (Re-organized)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422863
##########
File path:
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthCheckerPublisher.java
##########
@@ -30,8 +30,7 @@
@Test
public void test() {
- HealthCheckerManager manager = new HealthCheckerManager();
- manager.register(new HealthChecker() {
+ HealthCheckerManager.getInstance().register(new HealthChecker() {
Review comment:
Here you just check one HealthChecker. The test should test at least
zero?one and two HealthChecker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
