zhengyangyong commented on a change in pull request #562: [SCB-358] fix bug for
monitor output id that register only name without any tags
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/562#discussion_r171427234
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MonitorManager.java
##########
@@ -78,43 +82,58 @@ private void setupWindowTime() {
}
public Counter getCounter(String name, String... tags) {
- return counters.computeIfAbsent(getMonitorKey(name, tags), f -> {
- Counter counter = new BasicCounter(getConfig(name, tags));
- basicMonitorRegistry.register(counter);
- return counter;
- });
+ if (isCorrectMonitorNameAndTags(name, tags)) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
