WillemJiang commented on a change in pull request #574: [SCB-372] support user 
set metrics prometheus exporter address not only port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r173032038
 
 

 ##########
 File path: 
metrics/metrics-integration/metrics-prometheus/src/test/java/org/apache/servicecomb/metrics/prometheus/TestMetricsHttpPublisher.java
 ##########
 @@ -32,21 +31,18 @@
   public void testBadPublishAddress() {
     thrown.expect(ServiceCombException.class);
     new MetricsHttpPublisher("a:b:c");
-    Assert.fail("testPublishAddress failed : a:b:c");
   }
 
   @Test
   public void testBadPublishAddress_BadPort() {
     thrown.expect(ServiceCombException.class);
 
 Review comment:
   Need to check the Exception message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to