yangbor commented on a change in pull request #154: [SCB-260] Add third party notices URL: https://github.com/apache/incubator-servicecomb-saga/pull/154#discussion_r174379604
########## File path: saga-distribution/src/release/NOTICE ########## @@ -3,3 +3,19 @@ Copyright 2017-2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +================================================================ +Notice for gRPC + +See licenses/NOTICE-grpc Review comment: From my POV it's irrelevent where we put the NOTICE-xxx files so long as the end user can get those files. And put them under the licenses folder have the advantage that the end user can get all the legal information from one place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
