wujimin commented on a change in pull request #591: [SCB-396] java-sdk needs to
distinguish the instance belongs to the devops stage(environment)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#discussion_r174650338
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
##########
@@ -60,6 +62,7 @@ private Microservice
createMicroserviceFromDefinition(Configuration configuratio
microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration));
Map<String, String> propertiesMap =
MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration);
microservice.setProperties(propertiesMap);
+ microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV,
DEFAULT_SERVICECOMB_ENV));
Review comment:
PR title said that "instance" stage, but IMPL is microservice
so what's the real purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
