liubao68 closed pull request #608: [SCB-374] fix NPE when 404 not found
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/608
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
index 3932f1b86..3dfb5cc62 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
@@ -196,7 +196,11 @@ protected void sendResponseQuietly(Response response) {
e);
} finally {
requestEx.getAsyncContext().complete();
- invocation.onFinish(response);
+ // if failed to locate path, then will not create invocation
+ // TODO: statistics this case
+ if (invocation != null) {
+ invocation.onFinish(response);
+ }
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
