wujimin commented on a change in pull request #594: [SCB-379] support 
AsyncRestTemplate
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r177284484
 
 

 ##########
 File path: 
integration-tests/springmvc-tests/src/test/java/org/apache/servicecomb/demo/springmvc/tests/SpringMvcIntegrationTestBase.java
 ##########
 @@ -477,6 +659,13 @@ public void ableToSetCustomHeader() {
         String.class);
 
     assertThat(jsonOf(result.getBody(), String.class), is("hei world"));
+
+    ListenableFuture<ResponseEntity<String>> listenableFuture = 
asyncRestTemplate.exchange(controllerUrl + "sayhei",
+        GET,
+        requestEntity,
+        String.class);
+    ResponseEntity<String> responseEntity = listenableFuture.get();
 
 Review comment:
   all testcase is future.get, this is not the full async mode, please make 
sure async callback can work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to