WillemJiang commented on a change in pull request #633: [SCB-422] Threadpool metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179373890
########## File path: metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestDefaultRegistryInitializer.java ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.servicecomb.metrics.core; + +import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig; +import org.hamcrest.Matchers; +import org.junit.Assert; +import org.junit.Test; + +import com.google.common.eventbus.EventBus; +import com.netflix.spectator.api.CompositeRegistry; +import com.netflix.spectator.api.ManualClock; +import com.netflix.spectator.api.SpectatorUtils; +import com.netflix.spectator.servo.ServoRegistry; + +public class TestDefaultRegistryInitializer { + CompositeRegistry globalRegistry = SpectatorUtils.createCompositeRegistry(new ManualClock()); + + DefaultRegistryInitializer registryInitializer = new DefaultRegistryInitializer(); + + @Test + public void init() { + registryInitializer.init(globalRegistry, new EventBus(), new MetricsBootstrapConfig()); + + Assert.assertEquals(-10, registryInitializer.getOrder()); + Assert.assertThat(registryInitializer.getRegistry(), Matchers.instanceOf(ServoRegistry.class)); + + registryInitializer.uninit(); Review comment: What's the point of this line, we don't have any verification about it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
