wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179932881
##########
File path:
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestClientPool.java
##########
@@ -17,43 +17,16 @@
package org.apache.servicecomb.serviceregistry.client.http;
-import org.apache.servicecomb.serviceregistry.config.ServiceRegistryConfig;
import org.junit.Test;
-import io.vertx.core.http.HttpVersion;
-import mockit.Mock;
-import mockit.MockUp;
-
public class TestClientPool {
@Test
public void testHttpClientPool() {
- new MockUp<ServiceRegistryConfig>() {
- @Mock
- public HttpVersion getHttpVersion() {
- return HttpVersion.HTTP_2;
- }
-
- @Mock
- public boolean isSsl() {
- return true;
- }
- };
HttpClientPool.INSTANCE.create();
Review comment:
done
add new test cases for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
