WillemJiang commented on a change in pull request #637: [SCB-459]Update netty's 
version to 4.1.19 and vertx's version to 3.5.1
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/637#discussion_r179934986
 
 

 ##########
 File path: java-chassis-dependencies/pom.xml
 ##########
 @@ -32,7 +32,7 @@
 
   <properties>
     <jackson.version>2.9.4</jackson.version>
-    <vertx.version>3.5.0</vertx.version>
 
 Review comment:
   Please update the License file for the update.
   We need to update the NOTICE file as vertx 3.5.1 updated its NOTICE file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to