liubao68 commented on a change in pull request #637: [SCB-459]Update netty's 
version to 4.1.19 and vertx's version to 3.5.1
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/637#discussion_r179938539
 
 

 ##########
 File path: 
foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestVertxTLSBuilder.java
 ##########
 @@ -49,7 +49,7 @@ public void testbuildHttpServerOptions() {
     SSLCustom custom = SSLCustom.createSSLCustom(option.getSslCustomClass());
     HttpServerOptions serverOptions = new HttpServerOptions();
     VertxTLSBuilder.buildNetServerOptions(option, custom, serverOptions);
-    
Assert.assertEquals(serverOptions.getEnabledSecureTransportProtocols().toArray().length,
 1);
+    
Assert.assertEquals(serverOptions.getEnabledSecureTransportProtocols().toArray().length,
 3);
 
 Review comment:
   Why this has been changed? We need only enable TLS1.2+ only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to