lijasonvip commented on a change in pull request #636: SCB-189 fix CI problems
and warnings for feature support async restTe…
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#discussion_r179939180
##########
File path:
providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRequestCallbackTest.java
##########
@@ -28,27 +28,24 @@
@Test
public void testNormal() {
CseAsyncClientHttpRequest request = new CseAsyncClientHttpRequest();
- @SuppressWarnings("unchecked")
- CseAsyncRequestCallback cb = new CseAsyncRequestCallback(null);
+ CseAsyncRequestCallback<HttpEntity<String>> cb = new
CseAsyncRequestCallback<HttpEntity<String>>(null);
Review comment:
As HttpEntity is still a raw type here, this could cause a warning again.
how about `CseAsyncRequestCallback<HttpEntity<?>> cb = new
CseAsyncRequestCallback<>(null);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
