eric-lee-ltk commented on a change in pull request #647: [SCB-481]Fix qps
handler compatible issues due to assumption to schema ids not contains dot
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/647#discussion_r181271866
##########
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
##########
@@ -48,22 +46,22 @@
private String configKeyPrefix;
- public QpsController getOrCreate(String key) {
- return qualifiedNameControllerMap.computeIfAbsent(key, this::create);
+ public QpsController getOrCreate(String microerviceName, Invocation
invocation) {
+ return qualifiedNameControllerMap
+ .computeIfAbsent(microerviceName + SEPARATOR +
invocation.getOperationMeta().getSchemaQualifiedName(), key -> {
+ return create(key, microerviceName, invocation);
+ });
}
/**
* Create relevant qpsLimit dynamicProperty and watch the configuration
change.
* Search and return a valid qpsController.
*/
- protected QpsController create(String qualifiedNameKey) {
- if (!QUALIFIED_KEY_CHECKER.matcher(qualifiedNameKey).matches()) {
- throw new IllegalArgumentException("Unexpected qualified name: [" +
qualifiedNameKey + "]");
- }
+ protected QpsController create(String qualifiedNameKey, String
microerviceName, Invocation invocation) {
Review comment:
typo, microerviceName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
