jasononion commented on a change in pull request #632: [SCB-456]Provider a way 
to input configuration from a Map
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/632#discussion_r181541336
 
 

 ##########
 File path: 
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
 ##########
 @@ -52,9 +52,15 @@
 
   private static final String MICROSERVICE_CONFIG_LOADER_KEY = 
"cse-microservice-config-loader";
 
+  private static ConfigModel model = new ConfigModel();
+
   private ConfigUtil() {
   }
 
+  public static void setConfigs(Map<String, Object> config) {
 
 Review comment:
   you mean we provide both addConfig and setConfigs? or just replace 
setConfigs ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to