wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182644564
 
 

 ##########
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
 ##########
 @@ -50,7 +54,7 @@ public Response afterReceiveRequest(Invocation invocation, 
HttpServletRequestEx
   }
 
   @Override
-  public void beforeSendResponse(Invocation invocation, HttpServletResponseEx 
responseEx) {
+  public CompletableFuture<Void> asyncBeforeSendResponse(Invocation 
invocation, HttpServletResponseEx responseEx) {
 
 Review comment:
   done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to