wujimin commented on a change in pull request #658: [SCB-474] add endpoint
filter (only rest endpoints) for zuul integration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439746
##########
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/ServiceCombServerList.java
##########
@@ -49,13 +49,11 @@ public ServiceCombServerList() {
RegistryUtils.getAppId(),
serviceId,
DefinitionConst.VERSION_RULE_ALL);
- Map<String, MicroserviceInstance> servers = serversVersionedCache.data();
- List<Server> instances = new ArrayList<>(servers.size());
- for (MicroserviceInstance s : servers.values()) {
- for (String endpoint : s.getEndpoints()) {
- URIEndpointObject uri = new URIEndpointObject(endpoint);
- instances.add(new Server(uri.getHostOrIp(), uri.getPort()));
- }
+ ArrayList<Endpoint> endpoints = serversVersionedCache.data();
Review comment:
by previous comment, here will got `List<Server>`, not `List<Endpoint>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
