Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r183010311
##########
File path:
transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -127,7 +127,9 @@ private HttpServerOptions createDefaultHttpServerOptions()
{
serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
serverOptions.setCompressionSupported(TransportConfig.getCompressed());
serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
-
+ if (endpointObject.isHttp2Enabled()) {
Review comment:
for h2 mode we need to enable ALPN
but for h2c(with prior knowledge) no change is required on the server side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
