liubao68 commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#discussion_r183619964
##########
File path:
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/FallbackPolicyManager.java
##########
@@ -39,6 +42,7 @@ public static void record(String type, Invocation
invocation, Response response,
public static Response getFallbackResponse(String type, Throwable error,
Invocation invocation) {
FallbackPolicy policy = getPolicy(type, invocation);
if (policy != null) {
+ EventManager.post(new FallbackEvent(policy, invocation, Type.OPEN));
Review comment:
Fallback is called in HystrixCommand, send event there. But I think this
will send a lot of unnecessary events because any error will call fallback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
