liubao68 commented on a change in pull request #681: [SCB-526]fetch once from
dynamic config source when boot up
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/681#discussion_r185693012
##########
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
##########
@@ -354,9 +382,19 @@ public void refreshConfig(String configcenter) {
request.exceptionHandler(e -> {
EventManager.post(new ConnFailEvent("fetch config fail"));
LOGGER.error("Config refresh from {} failed. Error message is
[{}].", configcenter, e.getMessage());
+ latch.countDown();
});
request.end();
});
+ if (wait) {
Review comment:
I removed refresh member wait logic. Because we can use the configured
address and it's first time, no need to wait this operation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
