wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251016
##########
File path:
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java
##########
@@ -74,6 +83,7 @@ public void handle(Invocation invocation, AsyncResponse
asyncResp) {
HystrixObservable<Response> command =
delegate.createBizkeeperCommand(invocation);
Observable<Response> observable = command.toObservable();
+ eventAlarm(invocation);
Review comment:
// record that we are returning a short-circuited fallback
eventNotifier.markEvent(HystrixEventType.SHORT_CIRCUITED,
commandKey);
when allowRequest return false, will invoke this, it seems that we no need
to check everytime.
please check is it possible to optimize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
