Yes, I'll send an email of all the status of ongoing issues by tomorrow. We can discuss this then.
On Mon, May 7, 2018 at 5:34 PM, Zen Lin <[email protected]> wrote: > Hi YanBo, > > I think which release version can conclude the graceful shutdown is just > another topic, > but task about support graceful shutdown function in ServiceComb can be > start from now. > > Best Regards, > --- > Zen Lin > [email protected] > Focused on Micro Service and Apache ServiceComb > > 2018-05-07 17:30 GMT+08:00 Yang Bo <[email protected]>: > > > Do we have enough time to put this into 1.0.0-m2? I think we should > release > > m2 in early June. > > > > On Mon, May 7, 2018 at 5:27 PM, Zen Lin <[email protected]> > > wrote: > > > > > +1 > > > I think it will be very useful to the users , and users like Fujian > > Mobile > > > and Chinese People's Insurance also have repeatedly requested. > > > > > > Best Regards, > > > --- > > > Zen Lin > > > [email protected] > > > Focused on Micro Service and Apache ServiceComb > > > > > > 2018-05-07 17:21 GMT+08:00 Willem Jiang <[email protected]>: > > > > > > > Yeah, Let's put it into our 1.0.0-m2 release plan. > > > > > > > > Yangyong, do you mind create a JIRA for it? > > > > We can keep track it in our release plan. > > > > > > > > > > > > Willem Jiang > > > > > > > > Blog: http://willemjiang.blogspot.com (English) > > > > http://jnn.iteye.com (Chinese) > > > > Twitter: willemjiang > > > > Weibo: 姜宁willem > > > > > > > > On Mon, May 7, 2018 at 4:48 PM, 郑扬勇 <[email protected]> wrote: > > > > > > > > > Hi, All: > > > > > We did not implement gracefully shutdown yet: > > > > > > > > > > // 当程序退出时,进行相关清理,注意:kill -9 {pid}下无效 > > > > > // 1. 去注册实例信息 > > > > > // TODO 服务优雅退出 > > > > > if (applicationContext instanceof > > > AbstractApplicationContext) { > > > > > ((AbstractApplicationContext) applicationContext). > > > > > registerShutdownHook(); > > > > > } > > > > > > > > > > And had got an issue : https://github.com/apache/ > > > > > incubator-servicecomb-java-chassis/issues/685 from user. > > > > > So i think it's time we must do it and remove this TODO ? > > > > > > > > > > Best Regards! > > > > > YangYongZheng > > > > > > > > > > > > > > > -- > > Best Regards, > > Yang. > > > -- Best Regards, Yang.
