little-cui closed pull request #345: SCB-564 Fix Capitalization of the ServiceName in the Service list URL: https://github.com/apache/incubator-servicecomb-service-center/pull/345
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/frontend/app/scripts/modules/serviceCenter/controllers/serviceInfoCtrl.js b/frontend/app/scripts/modules/serviceCenter/controllers/serviceInfoCtrl.js index 979523c4..82579444 100644 --- a/frontend/app/scripts/modules/serviceCenter/controllers/serviceInfoCtrl.js +++ b/frontend/app/scripts/modules/serviceCenter/controllers/serviceInfoCtrl.js @@ -24,7 +24,7 @@ angular.module('serviceCenter.sc') serviceInfo.data.services.forEach(function(services){ if(services.serviceId == serviceId){ $scope.serviceDetail = { - serviceName: services.serviceName.toUpperCase(), + serviceName: services.serviceName, status: services.status.toLowerCase(), appId: services.appId.toLowerCase(), version: services.version, diff --git a/frontend/app/scripts/modules/serviceCenter/controllers/servicesListCtrl.js b/frontend/app/scripts/modules/serviceCenter/controllers/servicesListCtrl.js index 6343a4d1..4d128720 100644 --- a/frontend/app/scripts/modules/serviceCenter/controllers/servicesListCtrl.js +++ b/frontend/app/scripts/modules/serviceCenter/controllers/servicesListCtrl.js @@ -101,7 +101,7 @@ angular.module('serviceCenter.sc', []) var headers = {"X-ConsumerId": service.serviceId}; if(filter && service.status.toLowerCase() === filter) { var servicesList = { - serviceName: service.serviceName.charAt(0).toUpperCase()+service.serviceName.slice(1).toLowerCase(), + serviceName: service.serviceName, status: service.status.toLowerCase(), appId: service.appId.toLowerCase(), version: service.version, @@ -124,7 +124,7 @@ angular.module('serviceCenter.sc', []) } if(!filter){ var servicesList = { - serviceName: service.serviceName.charAt(0).toUpperCase()+service.serviceName.slice(1).toLowerCase(), + serviceName: service.serviceName, status: service.status.toLowerCase(), appId: service.appId.toLowerCase(), version: service.version, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services