wujimin commented on a change in pull request #698: [SCB-546] bug fix
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187500931
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
##########
@@ -145,7 +145,7 @@ private boolean registerSchemas() {
String schemaId = entry.getKey();
String content = entry.getValue();
GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas);
- boolean exists = existSchema != null;
+ boolean exists = existSchema != null && existSchema.getSummary() != null;
Review comment:
SC support batch register schemas
we should swtich to new api
be careful that maybe will send too big request, need to split to multi
request by max size of limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
