liubao68 commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388681843 @wujimin ShutdownHookHandler is not so good, sometimes will block shutdown process cause of wrong statistics, must depend on timeout to make shutdown process continue. ----I don't know how this comes. Because ShutdownHookHandler will wait quit a long time much more than the request timeout. If the time reached there usually means timeout not properly set or some other bug. we should: 1.prevent create new consumer invocation ----This is have already done 2.prevent other find me ---We can not prevent it from actually happen and maybe time delay. 3.make accurate statistics ---The process is shutdown and we force close some unexpected invocations and I think the precision is not very important and accurate statistics can not be achieved. We are experiencing a lot of scenarios that can not be shutdown but need force to exit the program. Program not exit can cause more bad consequences.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
