Using glide or dep tool can achieve the effect of generating vendor. As sc already used glide to manage package and go mod is still the experimental feature in go 1.11, i think there is no need to changed it, we can just push the source code to repo.
------------------ ???????? ------------------ ??????: "Xiaoliang Tian"<[email protected]>; ????????: 2018??8??25??(??????) ????6:02 ??????: "dev"<[email protected]>; ????: Re: [DISCUSS]Add Vendor Sources Code In SC project I have tired go mod today, it is a good tool. consider about it glide is never a option, because it is recommending user to use dep. Mohammad Asif Siddiqui <[email protected]> ??2018??8??25?????? ????5:57?????? > +1 > > We can add the vendor to SC folder, this will ease out the development of > SC specially in China region where GFC blocks the downloading of google > libs. > > Regards > Asif > > > On Sat, 25 Aug 2018, 3:22 pm Yang Bo, <[email protected]> wrote: > > > +1 > > > > As for the Apache compliance, It's OK to include the vendor source code > in > > our repository. We can update the release script and exclude the vendor > > directory when releasing. > > > > On Sat, Aug 25, 2018 at 4:20 PM Kirin Wang <[email protected]> > > wrote: > > > > > +1 > > > But may be we need to confirm if there are Apache compliance issue > about > > > it ? > > > > > > Xiaoliang Tian <[email protected]> ??2018??8??25?????? > > > ????10:48?????? > > > > > > > +1 Agree > > > > the truth is go project can easily go into a dep hell and there is no > > dep > > > > tool can manage the complicated deps > > > > > > > > checkout how go project does > > > > https://github.com/istio/istio/tree/master/vendor > > > > https://github.com/coreos/etcd/tree/master/vendor > > > > > > > > dep management is torturing go developers now > > > > > > > > Sure <[email protected]> ??2018??8??25?????? ????10:39?????? > > > > > > > > > Developers from China complain it is hard to go get the 3rd depends > > > > source > > > > > code of sc. > > > > > I suggest add these source code in vendor directory in sc project, > > like > > > > > Istio and etcd project do. > > > > > > > > > > > > > -- > > Best Regards, > > Yang. > > >
