If the recovery policy is forward, it means we have to retry it. The user may not provide the compensation at this time. My suggestion is we just through an Abort Exception here to let the user do the manual recovery.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Mon, Oct 22, 2018 at 4:16 PM 新道场开张了 <[email protected]> wrote: > > I plan to support the setting locally. > Users can configure the maximum of retries for each transaction. > > > In addition, I still have a question about forwardPolicy. > Should Saga execute Compensation when the number of transaction failures > reaches the maximum of retries? > > > For example, a Saga transaction includes three sub transaction A -> B -> C, > and the maximum of retries is 10. > When A succeeded and B failed 10 times, should A execute compensation or not? > > > > > ------------------ 原始邮件 ------------------ > 发件人: "Willem Jiang"<[email protected]>; > 发送时间: 2018年10月18日(星期四) 晚上10:42 > 收件人: "dev"<[email protected]>; > > 主题: Re: [DISCUSS]The forwardPolicy of Saga should be able to > configurethemaximum of retries > > > > I think we should support to apply the setting globally or locally. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > On Thu, Oct 18, 2018 at 8:27 PM Zheng Feng <[email protected]> wrote: > > > > Is it a global configration for all the transactions or it can be applied > > for the specified one ? > > > > 新道场开张了 <[email protected]> 于2018年10月16日周二 下午5:17写道： > > > > > I create a new issue in JIRA. > > > issue address: > > > https://issues.apache.org/jira/browse/SCB-962 > > > > > > > > > > > > > > > ------------------ 原始邮件 ------------------ > > > 发件人: "Willem Jiang"<[email protected]>; > > > 发送时间: 2018年10月16日(星期二) 下午4:29 > > > 收件人: "dev"<[email protected]>; > > > > > > 主题: Re: [DISCUSS]The forwardPolicy of Saga should be able to configurethe > > > maximum of retries > > > > > > > > > > > > Yeah, it makes sense to add the maximum number of forward retry. > > > Could you fill a JIRA for it? > > > It could be great if you can send a PR of this issue :) > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Tue, Oct 16, 2018 at 4:22 PM 新道场开张了 <[email protected]> wrote: > > > > > > > > Hi, all: > > > > > > > > > > > > Currently, service comb saga would keep trying transaction part when > > > using forwardPolicy. > > > > The policy is sufficient for some situations, such as network > > > fluctuations or service unavailability temporarily. > > > > But for other situations like wrong address, wrong params or wrong SQL, > > > it is possible to cause saga retry infinitely. > > > > So, I recommend that Saga should be able to configure the maximum of > > > retries for forwardPolicy. > > > > When users configure the maximum of retries and transaction failed > > > repeatedly, Saga should throw exception or do backward. > > > > > > > > > > > > Best Wishes & Regards
