+1 Binding

Checked:
1. Release Notes
2. Run integration tests using the binaries 




------------------ ???????? ------------------
??????: "Yang Bo"<oaky...@gmail.com>;
????????: 2018??11??26??(??????) ????7:17
??????: "dev"<dev@servicecomb.apache.org>;

????: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.1.0 [RC-02]



+1 Binding

Checked:
1. Checksum and GPG signature OK.
2. Build from source OK.
3. Rat check on binary/source packages OK.
4. No unintended binaries in source.
5. Basic functionality OK(tested on linux).

Minor issue: The build script assumes that machine doing the build is a
debian based distro on installing nodejs and bower,
it's better we add support for other package managers, yum, zypper etc.


On Mon, Nov 26, 2018 at 6:18 PM Thandayuthapani subramanian <
thanushpa...@gmail.com> wrote:

> +1 non binding
>
> Checks Done:
> - Verified Hashes and Signatures
> - NOTICE/LICENSE files exist
> - ASF Headers present in source files
> - Checked for archive matching git tag
>
> Regards
> Thandayuthapani S
>
> On Fri, Nov 23, 2018 at 10:11 PM Mohammad Asif Siddiqui <
> asifdxtr...@apache.org> wrote:
>
> > Hi All,
> >
> > This is a call for a Vote to release Apache ServiceComb Service-Center
> > version 1.1.0 [RC-02]
> >
> > Release Notes :
> >
> https://github.com/apache/servicecomb-service-center/blob/master/docs/release/releaseNotes-1.1.0.md
> >
> >
> > Release Candidate :
> >
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.1.0/rc-02/
> >
> >
> > Release Tag :
> > https://github.com/apache/servicecomb-service-center/releases/tag/1.1.0
> >
> > Release CommitID : 49428294a99f2a475203a7ceb04ce8d5754feb77
> >
> > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> >
> > Guide to build the release from source :
> >
> https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
> >
> >
> > Voting will start now ( Friday, 23rd November, 2018) and will remain open
> > for at-least 72 hours, Request all PMC members to give their vote.
> >
> > [ ] +1 Release this package as 1.1.0
> > [ ] +0 No Opinion
> > [ ] -1 Do not release this package because....
> >
> > On the behalf of ServiceComb Team
> > Mohammad Asif Siddiqui
> >
>


-- 
Best Regards,
Yang.

Reply via email to