I have an another suggestion to handle changes(generally suggestions to handle
API changes for SDK):
we check the deprecated usage and print error and exit the boot up process,
log the suggestions to the user. For example, we change servicecomb.foo to
servicecomb.bar, if users configure servicecomb.foo, we quit the bootup
process, and suggest users to use servicebomb.bar.
This suggestion can make users integration is always the recommended way and
both SDK providers and users will benefit from the cooperation. However
sometimes users will get quite angry about changes when they integrated new
versions in a hurry and no integrations test for them to check the correctness.
How about this suggestion?
------------------ ???????? ------------------
??????: "Yang Bo"<[email protected]>;
????????: 2019??1??25??(??????) ????5:35
??????: "dev"<[email protected]>;
????: Re: [discuss] enhance boot log
+1 for collecting the important logs(warnings/errors) into a separate
place.
Perhaps we can also write this collected information both to the console
and to a designated log file.
The boot logs are so long that's almost impossible for someone to get the
meaningful information from them.
On Fri, Jan 25, 2019 at 5:02 PM Willem Jiang <[email protected]> wrote:
> Maybe we can add some lines in the release note to let the user know
> these warning messages are quit important when upgrading the
> java-chassis version.
> It's always good to write some upgrade documents to fill the information
> gap.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: ????willem
>
> On Fri, Jan 25, 2019 at 4:57 PM wjm wjm <[email protected]> wrote:
> >
> > sometimes, it just a warning, not fatal
> >
> > Willem Jiang <[email protected]> ??2019??1??25?????? ????4:53??????
> >
> > > If you want user to take a good look of the warning log, you can just
> > > abort the boot process by default.
> > > Just my 2 cents.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: ????willem
> > >
> > > On Fri, Jan 25, 2019 at 4:43 PM wjm wjm <[email protected]> wrote:
> > > >
> > > > currently, when we find something not so good during boot, we will
> print
> > > > log immediately
> > > > eg:
> > > >
> > > > - use deprecated configuration
> > > > - port listen failed
> > > > - ......
> > > >
> > > > most developers will not notice these important messages
> > > >
> > > > so maybe we can keep current implementation
> > > > and collect all the information, print them after boot
> > > > maybe like:
> > > > *************** important message ***************
> > > > warning:
> > > > 1.servicecomb.rest.client.thread-count is ambiguous, suggest to use
> > > > servicecomb.rest.client.verticle-count.
> > > > error:
> > > > 1.......
> > >
>
--
Best Regards,
Yang.
