Hi, zheng, Sheng Revert SQL have been in compensate method method automatically. We have completed this feature. You can see more detail from our example[1]. Also we have some issue [2] to do. shardingsphere-transaction-base-saga could be using in cloud native environment. I think this model is more effective.
[1] https://github.com/apache/incubator-shardingsphere-example/tree/dev/sharding-jdbc-example/transaction-example/transaction-base-saga-example <https://github.com/apache/incubator-shardingsphere-example/tree/dev/sharding-jdbc-example/transaction-example/transaction-base-saga-example> [2]https://github.com/sharding-sphere/shardingsphere-spi-impl/issues?q=is%3Aopen+is%3Aissue+label%3Asaga <https://github.com/sharding-sphere/shardingsphere-spi-impl/issues?q=is:open+is:issue+label:saga> ------------------ Zhao Jun Apache Sharding-Sphere & ServiceComb > On Apr 26, 2019, at 7:16 PM, Sheng Wu <wu.sheng.841...@gmail.com> wrote: > > Hi > > SkyWalking will do agent based auto instrumentation by runtime code > manipulate tech. So we would depend on SPI or particular interface. > SkyWalking plans to intercept some core APIs. > > ServiceComb could be supported in same way. > > I cc'd dev@skywalking > > Zhenxu Ke and Yuguang Zhao, you could share your design to Shardingsphere > community too. > > Zheng Feng <zh.f...@gmail.com>于2019年4月26日 周五下午7:02写道: > >> Thanks Sheng for pointing out this and I just wonder the SkyWalking will >> trace the transaction event according to the issue [1]. And this >> transaction event could have the common SPI interface with the different >> vendor implementation, e.g. the ServiceComb and the Seata ? >> >> Thanks, >> Zheng Feng >> >> [1] https://github.com/seata/seata/issues/714 >> >> Sheng Wu <wush...@apache.org> 于2019年4月26日周五 下午6:47写道: >> >>> Please be advised, SkyWalking and seata integration are ongoing too. >>> >>> https://github.com/seata/seata/issues/714 >>> >>> SkyWalking agent even will be binding in Seata TC binary release. >>> >>> As shardingsphere pmc are developing SkyWalking plugin too. Please be >>> careful, don't make the conflict. >>> >>> zhaojun <zhaoju...@126.com>于2019年4月26日 周五下午6:41写道: >>> >>>> Hi, all >>>> >>>> currently, we have integrated with saga using graph based engine in >>>> shardingsphere[1] >>>> it need us to collect all participated actual SQL, then submit to saga >>>> actuator in commit/rollback phase. >>>> if application crashed before invoking saga actuator, undo log of >> branch >>>> transaction SQL will not be saved, >>>> so recovery thread will not be executed correctly. >>>> >>>> it's better that encapsulating every actual SQL as a saga task in >>>> shardingsphere side, >>>> then submit to saga actuator realtime instead of batch processing all >> the >>>> SQLs at commit/rollback phase. >>>> this architecture will make the boundary more clear between >> shardingsphre >>>> and saga, currently we have done some additional works for integrating >>> saga. >>>> >>>> any thought? >>>> >>>> [1]: >>>> >>> >> https://github.com/sharding-sphere/shardingsphere-spi-impl/tree/master/sharding-transaction-spi-impl/sharding-transaction-base-spi-impl/sharding-transaction-base-saga >>>> < >>>> >>> >> https://github.com/sharding-sphere/shardingsphere-spi-impl/tree/master/sharding-transaction-spi-impl/sharding-transaction-base-spi-impl/sharding-transaction-base-saga >>>>> >>>> >>>> >>>> >>>> ------------------ >>>> Zhao Jun >>>> Apache Sharding-Sphere & ServiceComb >>>> >>>> -- >>> Sheng Wu >>> SkyWalking, Shardingsphere and Zipkin >>> >> > -- > Sheng Wu > SkyWalking, Shardingsphere and Zipkin