+1 I check done: - Git tag and commit id OK. - mvn clean install OK. - hashes and signature good.
Daniel Qian <chanjars...@gmail.com> 于2019年12月11日周三 上午10:30写道： > Every software has bugs, it's ok to release 0.2.0 > > Bin Ma <mabin1...@gmail.com> 于2019年12月10日周二 下午9:11写道： > > > > The issues involve in the test code and CI, and do not affect > > the functions of the binary and maven plugin. > > > > I suggest to go on to vote 0.2.0, the issues[1] can be fixed > > in the next version. > > > > any thought?@PMCs > > > > [1] https://issues.apache.org/jira/browse/SCB-1657 > > > > Wishes & Regards > > ------------------------------- > > Mabin > > > > > > > > sen sun <asd992825...@gmail.com> 于2019年12月10日周二 上午11:38写道： > > > > > I have created the JIRA: > https://issues.apache.org/jira/browse/SCB-1657 > > > Whether this issue affects the current release? Can we fix it in the > next > > > version? > > > > > > Willem Jiang <willem.ji...@gmail.com> 于2019年12月10日周二 上午10:38写道： > > > > > > > Please create a JIRA to check this issue. > > > > We may consider to enable the Action in Github to running the CI with > > > > windows. > > > > > > > > Willem Jiang > > > > > > > > Twitter: willemjiang > > > > Weibo: 姜宁willem > > > > > > > > On Tue, Dec 10, 2019 at 9:46 AM sen sun <asd992825...@gmail.com> > wrote: > > > > > > > > > > Hi, @yhs0092 > > > > > > > > > > I have checked this unit test code. It uses File.size to get the > size > > > of > > > > > the directory. > > > > > In Windows, it always returns zero and causes the assertion to fail > > > > > In Linux, it is ok > > > > > This is because their file systems are different and Files.size > only > > > > > guarantee the correctness of the file > > > > > > > > > > yhs0092 <yhs0...@163.com> 于2019年12月10日周二 上午12:16写道： > > > > > > > > > > > Hello, I find that the `mvn clean install` build is not OK in my > > > > > > development environment. I use a Windows computer to run it. > > > > > > Here is the error log: > > > > > > ``` > > > > > > [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest > > > > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time > > > elapsed: > > > > > > 2.884 s <<< FAILURE! - in > org.apache.servicecomb.toolkit.cli.CliTest > > > > > > [ERROR] > > > > > > > > > > > > > > testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest) > > > > > > Time elapsed: 0.834 s <<< FAILURE! > > > > > > java.lang.AssertionError > > > > > > at > > > > > > > > > > > > > > org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54) > > > > > > at > > > > > > > > > > > > > > org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36) > > > > > > > > > > > > > > > > > > [ERROR] > > > > > > > > > > > > > > testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest) > > > > > > Time elapsed: 0.602 s <<< FAILURE! > > > > > > java.lang.AssertionError > > > > > > at > > > > > > > > > > > > > > org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89) > > > > > > > > > > > > > > > > > > [INFO] > > > > > > [INFO] Results: > > > > > > [INFO] > > > > > > [ERROR] Failures: > > > > > > [ERROR] CliTest.testGenerateCodeFromMultiContract:89 > > > > > > [ERROR] > > > > > > > > > > > > > > CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54 > > > > > > [INFO] > > > > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0 > > > > > > ``` > > > > > > > > > > > > > > > > > > Yours sincerely > > > > > > > > > > > > > > > > > > Yao Haishi > > > > > > yhs0...@163.com > > > > > > > > > > > > > > > > > > On 12/6/2019 09:09，Bin Ma<mabin1...@gmail.com> wrote： > > > > > > Hi All, > > > > > > > > > > > > This is a call for Vote to release Apache ServiceComb Toolkit > version > > > > 0.2.0 > > > > > > > > > > > > > > > > > > Release Candidate : > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/ > > > > > > > > > > > > Staging Repository : > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheservicecomb-1409 > > > > > > > > > > > > Release Tag : > > > > > > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0 > > > > > > > > > > > > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e > > > > > > > > > > > > Release Notes : > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158 > > > > > > > > > > > > Keys to verify the Release Candidate : > > > > > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS > > > > > > > > > > > > Voting will start now ( Friday, 6nd Dec, 2019) and will remain > open > > > for > > > > > > at-least 72 hours, Request all PMC members to give their vote. > > > > > > > > > > > > [ ] +1 Release this package as 0.2.0 > > > > > > [ ] +0 No Opinion > > > > > > [ ] -1 Do not release this package because.... > > > > > > > > > > > > On the behalf of ServiceComb Team > > > > > > > > > > > > > > > > > > Wishes & Regards > > > > > > ------------------------------- > > > > > > Mabin > > > > > > > > > > > > > > > > > -- > Daniel Qian > Apache Committer(chanjarster) > blog：https://chanjarster.github.io > github：https://github.com/chanjarster > segmentfault: https://segmentfault.com/u/chanjarster >
