+1
Checks done:
- git tag and commit id is OK.
- mvn build OK
- mvn build demo OK
- staging repo OK
- asc signature of source and binary OK
- sha512 signature of source and binary OK
Bao Liu <liu...@apache.org> 于2020年2月19日周三 下午2:33写道：
>
> Hi Daniel,
> Thank for the information. I guest the problem to run in MAC is because the
> test code got some problem, here is the test code and hard coded the local
> host. Maybe we can change it
> to 127.0.0.1, I created a issue [1] to update this in next release.
>
> public static class TestClientVerticle extends AbstractVerticle {
> @SuppressWarnings("deprecation")
> @Override
> public void start(Future<Void> startFuture) {
> HttpClient client = vertx.createHttpClient();
> client.post(port, "127.127.127.127", "/").handler(resp -> {
> resp.bodyHandler((buffer) -> {
> startFuture.complete();
> });
> }).end(body);
> }
> }
>
> And for the demo problem, I create an issue to update the document [2], there
> are still a lot of work to be done to update official site for other parts. I
> will start this work after the voting is closed. To run demo in docker, you
> need do the following:
> -Ddemo-run-release
> Or the dependencies will not copied to docker environment and cause your
> problem.
>
> [1]https://issues.apache.org/jira/browse/SCB-1779
> [2]https://issues.apache.org/jira/browse/SCB-1778
>
> Anyway, I think this two problems are not blocking the release and the voting
> can go on.
>
> On 2020/02/19 04:07:34, Daniel Qian <chanjars...@gmail.com> wrote:
> > Hi, Bao Liu
> >
> > I checked source code by method mentioned in offitial website link[1].
> > I used both `mvn clean install -Pdocker -Pit ` and `mvn clean install
> > -Pdocker -Pdemo-run-release -Pit`, and
> > `org.apache.servicecomb.metrics.core.TestVertxMetersInitializer` was
> > stucked, here is the stack trace generated by jstack[2]. BTW, the
> > issue is only reproducible on my Mac, not reproducible on a linux
> > machine, so I think it's not an issue.
> >
> > Besides, I checked Staging Repository by cd into demo and run `mvn
> > clean install -Pdocker -Pstaging ` (this method is also mentioned in
> > the official website[4]). Unfortunately, the build failed on `Java
> > Chassis::Demo::POJO::Client`, here is the error log[3]
> >
> > [1]:
> > https://servicecomb.apache.org/cn/developers/release-validation-guide/#%E9%AA%8C%E8%AF%81%E6%BA%90%E4%BB%A3%E7%A0%81%E5%8A%9F%E8%83%BD%E6%AD%A3%E7%A1%AE
> > [2]:
> > https://gist.github.com/chanjarster/614f349205ffd712b64afd041973b9a7#file-stack-txt
> > [3]:
> > https://gist.github.com/chanjarster/614f349205ffd712b64afd041973b9a7#file-demo-log
> > [4]:
> > https://servicecomb.apache.org/cn/developers/release-validation-guide/#%E9%AA%8C%E8%AF%81staging-repository%E5%86%85%E7%9A%84%E5%BA%93%E6%AD%A3%E7%A1%AE
> >
> > Bao Liu <liu...@apache.org> 于2020年2月18日周二 下午10:24写道：
> > >
> > > BTW, when running in profile -Ddocker, do not miss `mvn clean install
> > > -Pdocker -Pdemo-run-release -Pit` , -Ddemo-run-release is for integration
> > > tests in demo folder to execute. Check scripts/travis.sh for details.
> > >
> > > On 2020/02/18 14:21:07, Bao Liu <liu...@apache.org> wrote:
> > > > This is a unit test case and I run both locally and travis CI fine. Do
> > > > you have any details about the stuck?
> > > >
> > > > On 2020/02/18 12:31:27, Daniel Qian <chanjars...@gmail.com> wrote:
> > > > > I got stuck on
> > > > > org.apache.servicecomb.metrics.core.TestVertxMetersInitializer
> > > > > when mvn clean install -Pdocker -Pit
> > > > > Did I miss something?
> > > > >
> > > > > yhs0092 <yhs0...@163.com> 于2020年2月18日周二 下午4:19写道：
> > > > > >
> > > > > > +1
> > > > > > Checks done:
> > > > > > - git tag and commit id is OK.
> > > > > > - mvn clean install -Pit build OK.
> > > > > > - basic function checked pass.
> > > > > > - the release candidate of source is OK.
> > > > > >
> > > > > >
> > > > > > Yours sincerely
> > > > > >
> > > > > >
> > > > > > Yao Haishi
> > > > > > yhs0...@163.com
> > > > > >
> > > > > >
> > > > > > On 2/17/2020 16:07，bismy<bi...@qq.com> wrote：
> > > > > > Hello All,
> > > > > >
> > > > > > This is a call for a Vote to release Apache ServiceComb
> > > > > > Java-Chassis version 2.0.0
> > > > > >
> > > > > > Release Notes :
> > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12345196
> > > > > >
> > > > > > Release Candidate :
> > > > > > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-java-chassis/2.0.0/rc01//
> > > > > >
> > > > > > Staging Repo :
> > > > > > https://repository.apache.org/content/repositories/orgapacheservicecomb-1420
> > > > > >
> > > > > > Release Tag :
> > > > > > https://github.com/apache/servicecomb-java-chassis/releases/tag/2.0.0
> > > > > >
> > > > > > Release CommitID : 16ee95b968e0ed8beed26bd9fdecb56376984f7d
> > > > > >
> > > > > > Keys to verify the Release Candidate
> > > > > > :https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > > > > >
> > > > > > Voting will start now ( Monday, 27 February, 2020) and will remain
> > > > > > openfor at-least 72 hours, Request all PMC members to give their
> > > > > > vote.
> > > > > >
> > > > > > [ ] +1 Release this package as 2.0.0
> > > > > > [ ] +0 No Opinion
> > > > > > [ ] -1 Do not release this package because....
> > > > > >
> > > > > > On the behalf of ServiceComb Team
> > > > > >
> > > > > > Liu Bao
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Daniel Qian
> > > > > Apache Committer(chanjarster)
> > > > > blog：https://chanjarster.github.io
> > > > > github：https://github.com/chanjarster
> > > > > segmentfault: https://segmentfault.com/u/chanjarster
> > > > >
> > > >
> >
> >
> >
> > --
> > Daniel Qian
> > Apache Committer(chanjarster)
> > blog：https://chanjarster.github.io
> > github：https://github.com/chanjarster
> > segmentfault: https://segmentfault.com/u/chanjarster
> >
--
Daniel Qian
Apache Committer(chanjarster)
blog：https://chanjarster.github.io
github：https://github.com/chanjarster
segmentfault: https://segmentfault.com/u/chanjarster
