[GitHub] [servicecomb-mesher] superufo opened a new issue #119: 小bug?

[GitBox]

superufo opened a new issue #119:
URL: https://github.com/apache/servicecomb-mesher/issues/119


   https://github.com/apache/servicecomb-mesher/blob/master/proxy/cmd/cmd.go
   
   func parseConfigFromCmd(args []string) (err error) {
        app := cli.NewApp()
        app.HideVersion = true
        app.Usage = "a service mesh that governance your service traffic."
        app.Flags = []cli.Flag{
                cli.StringFlag{
                        Name:        "config",
                        Usage:       "mesher config file, example: 
--config=mesher.yaml",
                        Destination: &Configs.ConfigFile,
                },
                cli.StringFlag{
                        Name:  "mode",
                        Value: common.RoleSidecar,
                        Usage: fmt.Sprintf("mesher role [ %s|%s|%s ]",
                                common.RolePerHost, common.RoleSidecar, 
common.RoleEdge),
                        Destination: &Configs.Role,
                },
                cli.StringFlag{
                        Name:        "service-ports",
                        EnvVar:      common.EnvServicePorts,
                        Usage:       fmt.Sprintf("service protocol and 
port,examples: --service-ports=http:3000,grpc:8000"),
                        Destination: &Configs.LocalServicePorts,
                },
        }
        app.Action = func(c *cli.Context) error {
                return nil
        }
   
        err = app.Run(args)
        return
   }
   
   **这句代码 EnvVar:      common.EnvServicePorts,   应该 是 EnvVar:  
os.Getenv(common.EnvServicePorts),  吧？ 求证 ？ ** 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org