I have done the refactoring[1] and pushed it to the branch[2]

All tests passed

[1] https://issues.apache.org/jira/browse/SCB-2425
[2] https://github.com/apache/servicecomb-pack/tree/SCB-2425



Lei Zhang <zhang...@apache.org> 于2022年3月22日周二 17:38写道:

> Yes, refactoring needs a big amount of work.
> I will refactor with minimal changes and keep the test cases.
> After the first version is refactored and tested, I will push a new branch
> to the upstream repository.
>
> Feel free to contact me with any suggestions.
>
> Willem Jiang <willem.ji...@gmail.com> 于2022年3月22日周二 17:20写道:
>
>> Just a quick commons about it.
>> It looks like the user can take control of which module he wants to
>> use by specifying the alpha.spec.names.
>> But those modules can have some conflicts, I think we need to double
>> check the setting of these modules.
>>
>>
>>
>> Willem Jiang
>>
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>> On Tue, Mar 22, 2022 at 3:54 PM Lei Zhang <zhang...@apache.org> wrote:
>> >
>> > Hi, pack
>> >
>> > I created a Jira issue https://issues.apache.org/jira/browse/SCB-2425.
>> >
>> > Lei Zhang
>> >
>> > Best Regards
>>
>

Reply via email to