[
https://issues.apache.org/activemq/browse/SM-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40708
]
Guillaume Nodet commented on SM-1065:
-------------------------------------
Hi Jeff, a few comments on this patch.
* Including the activemq.xml using a classpath can be a problem because users
won't be able to change it easily. Maybe we could put it outside the bundle in
the ./conf /activemq.xml location in the binary distribution and use the
${servicemix.home}/conf/activemq.xml inside the spring config ? It should work
as ${servicemix.home} should be resolved as a system property.
* You should use xbean 3.3-SNAPSHOT. Those jars are now OSGi bundles, so
there is no need to put them inside our activemq bundle. For jencks, I suppose
a better solution would be to provide a patch so that they also become bundles
(but it can wait a bit)
*About the transaction manager, I think you missed a point. The code you
point will make sure the session is enlisted as an xa resource in the
transaction manager. The recovery process is another unrelated thing which
occurs when the system restarts. If a transaction was in progress, the
transaction manager needs to handle those *recovered* transactions. For that,
it needs to have the list of transactions that were in progress.
This is done when the transaction manager calls
XaResource.recover()
But we need to give the transaction manager an XaResource at start time (only
one) so that it can retrieve the transaction ids.
So when the broker is started, I think we need an additional bean that will do:
((RecoverableTransactionManager)
txManager).recoverResourceManager(namedXaRes)
where namedXaRes is a wrapper that could be created by the jcaPooledConnection
(it has to have the same name)
AFAIK, noone calls recoverResourceManager automatically, so we have to do it
outselves.
Did I miss somehting ?
> ActiveMQ integration
> --------------------
>
> Key: SM-1065
> URL: https://issues.apache.org/activemq/browse/SM-1065
> Project: ServiceMix
> Issue Type: New Feature
> Reporter: Guillaume Nodet
> Assignee: Jeff Yu
> Fix For: 4.0
>
> Attachments: SM-1065.patch, SMX-1065-2.patch
>
>
> ActiveMQ jars are already OSGified, but we may want to create a bundle that
> would create a broker by default and registering a pooled connection factory
> in OSGi maybe. That way, everyone could use the ConnectionFactory registered
> in OSGi.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
