[
https://issues.apache.org/activemq/browse/SM-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40766
]
Guillaume Nodet commented on SM-1090:
-------------------------------------
Good work !
Still, I have a few problems with the patch:
* i can't launch the shell script on mac (haven't looked why yet)
does it work on other unix systems ? If you don't have any available, i
can handle that
* the tool only handles components so far, we need to also handle SLs and SAs
by extracting
the informations from the jbi descriptor if available or from the
manifest if not
* the shell scripts includes the version number which is a really bad idea,
as it would require manual editing
before releasing. There are two solutions to that: just rename the jar
"convert.jar" or use the the maven
resource filtering to put the version number at build time (i'd rather use
the first one).
> JBI 1.0 compatibility layer: Offline tool to transform JBI artifacts in OSGi
> bundles
> ------------------------------------------------------------------------------------
>
> Key: SM-1090
> URL: https://issues.apache.org/activemq/browse/SM-1090
> Project: ServiceMix
> Issue Type: New Feature
> Reporter: Guillaume Nodet
> Assignee: Jeff Yu
> Fix For: 4.0
>
> Attachments: SM-1090.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
