I am not a contributor but because I fought with checkstyle on
servicemix beforehand I thought I share my 2 cents.
I would assume that anyone working as a contributor in an open-source
project is able to read code even if it is not formated as he is used
to and so I don't see the need to use checkstyle to force a certain
formatting. Even the suggestion that one could use a tool inside an
IDE that helps to format may not work good because not everyone is
using the same IDE (I heard some are still using VI) and even if they
might work on different project using different "coding guidelines". I
did not testing with the ServiceMix checkstyle and it turned out that
I still can write some ugly looking code. Therefore I would think that
not formatting should be enforced with checkstyle.
That said I would still use checkstyle to enforce some problematic
code that leads easily to errors like "single line block" or
overwriting member variables.
Finally due to the fact that bad documentation or wrong documentation
is worse than none I would also suggest that no enforcing of JavaDoc
is done as well. Just saying that this method is a setter for a member
is worthless and makes the class harder to read because it is longer a
few lines.
Have fun - Andy
On Dec 7, 2007, at 6:31 AM, Guillaume Nodet wrote:
I'm fine with that.
On Dec 6, 2007 8:04 AM, Bruce Snyder <[EMAIL PROTECTED]> wrote:
Because these checks drive me crazy, I'd prefer to make the nochecks
profile the default. What do others think?
BTW, if we were automatically formatting the code with Jalopy or
something similar I wouldn't mind so much, but we're not doing that
currently and I'm not sure we want to do that as it's rather
heavy-handed.
Bruce
--
perl -e 'print
unpack("u30","D0G)[EMAIL PROTECTED]&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
);'
Apache ActiveMQ - http://activemq.org/
Apache ServiceMix - http://servicemix.org/
Apache Geronimo - http://geronimo.apache.org/
http://bruceblog.org/
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
